Add config and dev dependency for starting to use phan #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garvinhicking You preferred a different checker than phan, right? Should I go ahead and close here, or should I finish this up to merge it? |
|
I think phan isn't the community's choice these days, phpstan is quite on top of things. However that one doesnt provide a phar, so we'd need a composer dependency for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phan enables a static code analysis and seems to be highly configurable. The goal is to have it enabled, to:
This PR sets a minimal configuration that should identify some compatibility issues. Run it with:
Please note: Installing phan included updating the PHP version in the composer.json and lead to lots of updates in bundled-libs. If we merge #757 first we can clean that up a bit.
I'm still investigating alternative options myself.